Skip to content

Conversation

@lfdevs
Copy link

@lfdevs lfdevs commented Feb 12, 2026

Copy link
Member

@TomJo2000 TomJo2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version bump seems fine, but I think the additional patches for additional GPU support should probably be in one or more separate commits.

@lfdevs
Copy link
Author

lfdevs commented Feb 12, 2026

The version bump seems fine, but I think the additional patches for additional GPU support should probably be in one or more separate commits.

Okay, I have split the additional patches for additional GPU support into two additional commits.

Copy link
Member

@TomJo2000 TomJo2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Although I think the UBWC patch should probably also be a separate commit.

I'm gonna mark this as an approval in the meantime since everything else checks out.

@lfdevs
Copy link
Author

lfdevs commented Feb 12, 2026

LGTM. Although I think the UBWC patch should probably also be a separate commit.

I'm gonna mark this as an approval in the meantime since everything else checks out.

Okay, I have split it into a new commit. If upstream perfects and merges this MR in the future, it will facilitate the easy removal of this patch.

@TomJo2000
Copy link
Member

If the MR lands in a future version of Mesa we'll find out as soon as the patch fails to apply.

@813ethan
Copy link
Contributor

There're some additional fixes from whitebeylash for Adreno 810 and 829, mind adding them into this pr?

whitebelyash/mesa-tu8@9e646d5
whitebelyash/mesa-tu8@e5ee340
whitebelyash/mesa-tu8@10c83bf

@robertkirkman
Copy link
Member

robertkirkman commented Feb 12, 2026

Good job, it's working great on Adreno 612 and Adreno 630

@DuilioPerez is it working for Adreno 710?

@TomJo2000
Copy link
Member

Good job, it's working great on Adreno 612 and Adreno 630

@DuilioPerez is it working for Adreno 710?

What did you use for testing?
I can try on my device, apparently it has a Adreno 643.

@robertkirkman
Copy link
Member

eglinfo -B, glxinfo -B, luanti, blender-5.0

@DuilioPerez
Copy link

Good job, it's working great on Adreno 612 and Adreno 630

@DuilioPerez is it working for Adreno 710?

On my devices still have graphic artifacts, but it's working:
Screenshot_20260212_074227_TermuxX11

@robertkirkman
Copy link
Member

For the understanding of others reading, the screenshot with Adreno 710 is exactly what it looks like with current Mesa 25

@DuilioPerez
Copy link

There's a bit of improvement, in mesa 25 just visual noise was rendered:
Screenshot_20260212_080315_TermuxX11

@lfdevs
Copy link
Author

lfdevs commented Feb 12, 2026

There're some additional fixes from whitebeylash for Adreno 810 and 829, mind adding them into this pr?

whitebelyash/mesa-tu8@9e646d5 whitebelyash/mesa-tu8@e5ee340 whitebelyash/mesa-tu8@10c83bf

I checked the state of the repository at the time of whitebelyash's latest commit; the changes regarding a810, a825, and a829 in src/freedreno/common/freedreno_devices.py are actually already included in the patch 0021-unofficial-support-adreno-810-825-829.patch.

However, I have also added whitebelyash's changes to src/freedreno/drm-shim/freedreno_noop.c into 0021-unofficial-support-adreno-810-825-829.patch now, which might be useful for the drm-shim of a810 and a829.

disable_gmem can achieve the same effect by using the environment variable TU_DEBUG=sysmem. Regarding whitebelyash's other more hacky patches, I think they can be added in the future after more testing and evaluation.

@robertkirkman
Copy link
Member

Ok I will merge it in 24 hours if no problems are found

lfdevs and others added 3 commits February 12, 2026 23:10
It's necessary for Adreno 8xx on Android KGSL.
The patch is from Rob Clark:
https://gitlab.freedesktop.org/mesa/mesa/-/commit/2da45c609845854491c09bd26d9d8245834ea4af?merge_request_iid=39358

UBWC is Qualcomm's Universal Bandwidth Compression. Adreno 8xx uses new versions
of UBWC (`5` and `6`), but using older version configurations still works normally.
Rob Clark actually does not have an Android environment to continue developing this MR:
https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/39358
So this patch has not been merged upstream, but it is understandable.
If upstream perfects and merges this MR, this patch can then be safely removed.
Modified based on Adreno 840, most features should work.
@lfdevs
Copy link
Author

lfdevs commented Feb 12, 2026

Refined the commit message for the patch 0019-UBWC_5-and-UBWC_6-support.patch.

enhance(main/mesa): add UBWC_5 and UBWC_6 support

It's necessary for Adreno 8xx on Android KGSL.
The patch is from Rob Clark:
https://gitlab.freedesktop.org/mesa/mesa/-/commit/2da45c609845854491c09bd26d9d8245834ea4af?merge_request_iid=39358

UBWC is Qualcomm's Universal Bandwidth Compression. Adreno 8xx uses new versions
of UBWC (`5` and `6`), but using older version configurations still works normally.
Rob Clark actually does not have an Android environment to continue developing this MR:
https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/39358
So this patch has not been merged upstream, but it is understandable.
If upstream perfects and merges this MR, this patch can then be safely removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants