-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
bump(main/mesa): 26.0.0 #28431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
bump(main/mesa): 26.0.0 #28431
Conversation
TomJo2000
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version bump seems fine, but I think the additional patches for additional GPU support should probably be in one or more separate commits.
Okay, I have split the additional patches for additional GPU support into two additional commits. |
TomJo2000
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Although I think the UBWC patch should probably also be a separate commit.
I'm gonna mark this as an approval in the meantime since everything else checks out.
Okay, I have split it into a new commit. If upstream perfects and merges this MR in the future, it will facilitate the easy removal of this patch. |
|
If the MR lands in a future version of Mesa we'll find out as soon as the patch fails to apply. |
|
There're some additional fixes from whitebeylash for Adreno 810 and 829, mind adding them into this pr? whitebelyash/mesa-tu8@9e646d5 |
|
Good job, it's working great on Adreno 612 and Adreno 630 @DuilioPerez is it working for Adreno 710? |
What did you use for testing? |
|
|
On my devices still have graphic artifacts, but it's working: |
|
For the understanding of others reading, the screenshot with Adreno 710 is exactly what it looks like with current Mesa 25 |
I checked the state of the repository at the time of whitebelyash's latest commit; the changes regarding a810, a825, and a829 in However, I have also added whitebelyash's changes to
|
|
Ok I will merge it in 24 hours if no problems are found |
It's necessary for Adreno 8xx on Android KGSL. The patch is from Rob Clark: https://gitlab.freedesktop.org/mesa/mesa/-/commit/2da45c609845854491c09bd26d9d8245834ea4af?merge_request_iid=39358 UBWC is Qualcomm's Universal Bandwidth Compression. Adreno 8xx uses new versions of UBWC (`5` and `6`), but using older version configurations still works normally. Rob Clark actually does not have an Android environment to continue developing this MR: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/39358 So this patch has not been merged upstream, but it is understandable. If upstream perfects and merges this MR, this patch can then be safely removed.
Modified based on Adreno 840, most features should work.
The source code is from whitebelyash: whitebelyash/mesa-tu8@cce699c whitebelyash/mesa-tu8@6422f96 whitebelyash/mesa-tu8@16ada8f whitebelyash/mesa-tu8@849fd6e whitebelyash/mesa-tu8@9e646d5#diff-e274069ac3672d59739117992d22f15bc2712d5887b33574fc1b421292694228 Co-authored-by: whitebelyash <[email protected]>
|
Refined the commit message for the patch |


whitebelyash/mesa-tu8@cce699c
whitebelyash/mesa-tu8@6422f96
whitebelyash/mesa-tu8@16ada8f
whitebelyash/mesa-tu8@849fd6e
whitebelyash/mesa-tu8@9e646d5#diff-e274069ac3672d59739117992d22f15bc2712d5887b33574fc1b421292694228