feat!: Handle new region parameter introduced in terraform-aws 6.0

[guillaumelecerf]

Description

Handle the new region parameter introduced in terrafrom-aws provider 6.0.

Motivation and Context

This allows to specify the region to create the resources into, instead of relying on a dedicated provider instance.

Breaking Changes

This requires terraform-aws >= 6.0.

How Has This Been Tested?

• I have updated at least one of the examples/* to demonstrate and validate my change(s)
• I have tested and validated these changes using one or more of the provided examples/* projects
• I have executed pre-commit run -a on my pull request

[antonbabenko]

@bryantbiggs WDYT? Should we add support for the newly introduced "region" argument in all Terraform AWS modules? I personally think - yes, but I am trying to think about different scenarios when this can be a bad idea.

[antonbabenko]

Waiting for Bryant's feedback... I think we should add region on all resources, even if some of them are rather global (like aws_route53_record).

[guillaumelecerf]

Waiting for Bryant's feedback... I think we should add region on all resources, even if some of them are rather global (like aws_route53_record).

Unfortunately, global resources like aws_route53_record do not support the region parameter, that's why I didn't add it.

[bryantbiggs]

@bryantbiggs WDYT? Should we add support for the newly introduced "region" argument in all Terraform AWS modules? I personally think - yes, but I am trying to think about different scenarios when this can be a bad idea.

yes, I completely agree. since this is a breaking change, could we also bump the MSV of Terraform to at least 1.10.0 as well? this covers both the optional variable attributes and the new ephemeral secrets/inputs

[guillaumelecerf]

yes, I completely agree. since this is a breaking change, could we also bump the MSV of Terraform to at least 1.10.0 as well? this covers both the optional variable attributes and the new ephemeral secrets/inputs

I pushed a new commit, tell me if it's OK for you.

[antonbabenko]

This PR is included in version 6.0.0 🎉

[guillaumelecerf]

👍 thanks a lot to both of you for your responsiveness!

[globart]

@bryantbiggs WDYT? Should we add support for the newly introduced "region" argument in all Terraform AWS modules? I personally think - yes, but I am trying to think about different scenarios when this can be a bad idea.

yes, I completely agree. since this is a breaking change, could we also bump the MSV of Terraform to at least 1.10.0 as well? this covers both the optional variable attributes and the new ephemeral secrets/inputs

@bryantbiggs I think you have to be careful with this, because as far as I know some people have TF version pinned at 1.5.x, because the license was changed to BSL from 1.6.0 onwards

[bryantbiggs]

I mean, unfortunately thats outside of our control. The license change should not affect module users - that should really only affect folks who have created a competing business and will have to adhere to the license

[sidick]

I mean, unfortunately thats outside of our control. The license change should not affect module users - that should really only affect folks who have created a competing business and will have to adhere to the license

Unfortunately it also breaks OpenTofu support

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.