-
-
Notifications
You must be signed in to change notification settings - Fork 700
feat!: Bump min supported version of Terraform and AWS to 1.5.7
and 6.5
respectively
#411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Bump min supported version of Terraform and AWS to 1.5.7
and 6.5
respectively
#411
Conversation
118145f
to
7aae878
Compare
cc @antonbabenko if you have time/feedback on the proposed changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very nice and clean!
examples/complete-nlb/variables.tf
Outdated
type = string | ||
default = "terraform-aws-modules.modules.tf" | ||
# default = "terraform-aws-modules.modules.tf" | ||
default = "sharedservices.clowd.haus" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe put it into terraform.tfvars
? I'm unsure which approach is best for both of us to be able to run these examples without manual changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah shoot - I normally just revert any changes to this but looks like I missed these
reverted in ba1e1cf
Co-authored-by: Anton Babenko <[email protected]>
0145d2d
to
ba1e1cf
Compare
This PR is included in version 10.0.0 🎉 |
6.5
respectively1.5.7
and 6.5
respectively
Description
List of backwards incompatible changes
v1.5.7
is now minimum supported versionv6.5
is now minimum supported versionAdditional changes
Added
region
parameter to specify the AWS region for the resources created if different from the provider region.Modified
object
types in place of the previously used any type.<security-group-name>-<map-key>
unless a more specific rule name is provided.rule.actions.type
has been replaced withrule.actions.<type>
. See before/after below for more details.query_string
supports a list of key:value pairs; type definition updated to support this (i.e. wasmap(string)
and is nowlist(map(string))
)Removed
Motivation and Context
Breaking Changes
docs/UPGRADE-10.0.md
guideHow Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull request