Skip to content

fix: Set default value for root_block_device.tags to null #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

lucasvuotto
Copy link
Contributor

Fixes #440. Without it, if root_block_device is defined without a tags
key, and if enable_volume_tags isn't set to false, a conflict is created
because main.tf:219 defines volume_tags to be at least { Name = ... }
and the root block device gets tags as {}. Making the default null works
around that.

@lucasvuotto lucasvuotto force-pushed the conflicting-root-volume-tags branch from 0a78af0 to fbc567b Compare July 1, 2025 12:59
@lucasvuotto lucasvuotto changed the title fix: make root_block_device.tags default to null fix: Make root_block_device.tags default to null Jul 1, 2025
Fixes terraform-aws-modules#440. Without it, if root_block_device is defined without a tags
key, and if enable_volume_tags isn't set to false, a conflict is created
because main.tf:219 defines volume_tags to be at least { Name = ... }
and the root block device gets tags as {}. Making the default null works
around that.
@lucasvuotto lucasvuotto force-pushed the conflicting-root-volume-tags branch from fbc567b to 8773893 Compare July 1, 2025 13:16
@bryantbiggs bryantbiggs changed the title fix: Make root_block_device.tags default to null fix: Set default value for root_block_device.tags to null Jul 1, 2025
@bryantbiggs bryantbiggs merged commit f1b5273 into terraform-aws-modules:master Jul 1, 2025
8 checks passed
antonbabenko pushed a commit that referenced this pull request Jul 1, 2025
## [6.0.2](v6.0.1...v6.0.2) (2025-07-01)

### Bug Fixes

* Set default value for `root_block_device.tags` to `null` ([#444](#444)) ([f1b5273](f1b5273))
@antonbabenko
Copy link
Member

This PR is included in version 6.0.2 🎉

Copy link

github-actions bot commented Aug 1, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors on tags
3 participants