Skip to content

fix: Correct loop extraction logic for tls.issuer_cert_authority #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 7, 2025
Merged

fix: Correct loop extraction logic for tls.issuer_cert_authority #337

merged 3 commits into from
Aug 7, 2025

Conversation

crashGoBoom
Copy link
Contributor

Description

This removes an unnecessary for_each and dynamic setting for issuer_cert_authority which is a required setting when using tls.

Motivation and Context

This fixes a bug:

Error: Unsupported attribute
on .terraform/modules/web_ecs_service/modules/service/main.tf line 257, in resource "aws_ecs_service" "this":
                  aws_pca_authority_arn = issuer_cert_authority.value.aws_pca_authority_arn
issuer_cert_authority.value is "arn:aws:acm-pca:us-east-2:SNIP:certificate-authority/SNIP"
Can't access attributes on a primitive-typed value (string).

Breaking Changes

No breaking changes.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@bryantbiggs bryantbiggs changed the title fix: Remove unnecessary for_each on tls.issuer_cert_authority fix: Correct loop extraction logic for tls.issuer_cert_authority Aug 7, 2025
bryantbiggs
bryantbiggs approved these changes Aug 7, 2025
View reviewed changes
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@bryantbiggs bryantbiggs merged commit e68b246 into terraform-aws-modules:master Aug 7, 2025
13 checks passed
antonbabenko pushed a commit that referenced this pull request Aug 7, 2025
@semantic-release-bot
chore(release): version 6.2.1 [skip ci]
2afaaaf 
## [6.2.1](v6.2.0...v6.2.1) (2025-08-07)

### Bug Fixes

* Correct loop extraction logic for `tls.issuer_cert_authority` ([#337](#337)) ([e68b246](e68b246))
@antonbabenko
Copy link
Member

This PR is included in version 6.2.1 🎉

@magreenbaum magreenbaum mentioned this pull request Aug 16, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crashGoBoom @antonbabenko @bryantbiggs