Skip to content

Conversation

@Atry
Copy link

@Atry Atry commented Oct 20, 2024

Description

This PR prevents helm_release.karpenter from being upgraded each time of terraform apply even when the main.tf is unchanged

Motivation and Context

Currently data.aws_ecrpublic_authorization_token can invalidate helm_release.karpenter even when the main.tf is unchanged

Breaking Changes

N/A

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

This PR prevents `helm_release.karpenter` from being upgraded each time of `terraform apply` even when the `main.tf` is unchanged
@Atry Atry changed the title Configure public.ecr.aws password in provider [fix] Configure public.ecr.aws password in provider Oct 21, 2024
@Atry Atry changed the title [fix] Configure public.ecr.aws password in provider fix: configure public.ecr.aws password in provider Oct 21, 2024
@Atry Atry changed the title fix: configure public.ecr.aws password in provider fix: Configure public.ecr.aws password in provider Oct 21, 2024
@Atry Atry marked this pull request as ready for review October 21, 2024 23:59
@bryantbiggs
Copy link
Member

thank you but this is just an example and where or how users wish to inject the authentication details is left up to them

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants