Skip to content

Conversation

@kimxogus
Copy link
Contributor

Description

Moved inline_policy in aws_iam_role to aws_iam_role_policy and aws_iam_role_policies_exclusive as force_detach_policies is true.

Motivation and Context

inline_policy block in aws_iam_role was deprecated since aws provider v5.68.0 as aws_iam_role_policies_exclusive was added.
hashicorp/terraform-provider-aws#39203
https://github.com/hashicorp/terraform-provider-aws/releases/tag/v5.68.0

Breaking Changes

No.
This change doesn't remove existing inline policies in migration process. I checked using TF_LOG=debug and there was no aws api call to remove existing inline policies.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@kimxogus kimxogus closed this Oct 31, 2024
@kimxogus kimxogus deleted the feature/iam_role_policies_exclusive branch October 31, 2024 03:11
@kimxogus
Copy link
Contributor Author

Sorry, my local fork was too outdated.

@github-actions
Copy link

github-actions bot commented Dec 1, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant