feat: Add support for creating efa-only network interfaces
#3196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryantbiggs
force-pushed
the
feat/efa-only
branch
from
f4b0228 to
6f02268
Compare
|
waiting for 2x |
|
antonbabenko
approved these changes
Nov 2, 2024
| device_index = i == 0 ? 0 : 1 | ||
| network_card_index = i | ||
| interface_type = "efa" | ||
| interface_type = var.enable_efa_only ? contains(concat([0], var.efa_indices), i) ? "efa" : "efa-only" : "efa" |
There was a problem hiding this comment.
contains(concat([0], var.efa_indices), i) looks almost like magic but I guess it works as expected. :)
There was a problem hiding this comment.
ya, hopefully on the next breaking change some of this can be simplified by changing the defaults 😅
antonbabenko
pushed a commit
that referenced
this pull request
Nov 2, 2024
## [20.28.0](v20.27.0...v20.28.0) (2024-11-02) ### Features * Add support for creating `efa-only` network interfaces ([#3196](#3196)) ([c6da22c](c6da22c))
|
This PR is included in version 20.28.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
efa-onlynetwork interfacesMotivation and Context
efa-onlyinterface types hashicorp/terraform-provider-aws#39882Breaking Changes
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request