fix: Fallback to clusters primary sg during node sg rule creation #3356
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a situation, where Terraform tries to create node security group rules with an empty string as
source_security_group_id
when the module is used with input variablecreate_cluster_security_group = false
.Motivation and Context
I'm migrating existing clusters to this module which do not use a secondary cluster security group.
Breaking Changes
None
Although I had to remove
depends_on { aws_security_group_rule.node }
fromaws_eks_cluster.this
to prevent a circular dependency all node groups and addons still depend on it via attributes. So the order of applied resources is still intact.How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectsTested with
examples/eks-auto-mode
andexamples/eks-managed-node-group
by addingcreate_cluster_security_group = false
, running apply, re-apply (without changes) and destroy.pre-commit run -a
on my pull request