Skip to content

Conversation

visit1985
Copy link

Description

This PR fixes a situation, where Terraform tries to create node security group rules with an empty string as source_security_group_id when the module is used with input variable create_cluster_security_group = false.

Motivation and Context

I'm migrating existing clusters to this module which do not use a secondary cluster security group.

Breaking Changes

None

Although I had to remove depends_on { aws_security_group_rule.node } from aws_eks_cluster.this to prevent a circular dependency all node groups and addons still depend on it via attributes. So the order of applied resources is still intact.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects

Tested with examples/eks-auto-mode and examples/eks-managed-node-group by adding create_cluster_security_group = false, running apply, re-apply (without changes) and destroy.

  • I have executed pre-commit run -a on my pull request

@visit1985
Copy link
Author

Hey @bryantbiggs, is there any thing I can help with, to speed up the review process for this PR?

Thanks

@bryantbiggs
Copy link
Member

this isn't a valid change - please start with an issue and a reproduction so we can take a look

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants