Skip to content

Conversation

ak2d
Copy link

@ak2d ak2d commented May 20, 2025

Description

Add support for cluster_cloudwatch_log_group_use_name_prefix

Motivation and Context

This change would eliminate the need to manually delete cloudwatch log groups when recreating clusters with identical names

Breaking Changes

No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@bryantbiggs
Copy link
Member

thank you for the PR - however, this is not a change that we are looking to support at this time

@ak2d
Copy link
Author

ak2d commented May 20, 2025

thank you for the PR - however, this is not a change that we are looking to support at this time

thanks for the quick feedback,

would you reconsider if the new parameter is false by default?
it keeps full backward compatibility and avoids breaking existing CloudWatch setups, while still offering flexibility for short-lived clusters.

@bryantbiggs
Copy link
Member

we do not want to bloat the module with more "knobs and levers" for edge cases. log groups are getting created in your scenario because applications are still logging when you are tearing down the cluster. its unfortunate, but not something that this module should try to solve for. instead, the recommendation is to always remove the applications running on the cluster first, then destroy the cluster and its resources after

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants