fix: Ensure additional_cluster_dns_ips is passed through from root module
#3376
Conversation
880831ian
changed the title
880831ian
changed the title
880831ian
changed the title
|
Hi, just a note for reviewers: I’ve tested this change using the following example: Without explicitly adding the additional_cluster_dns_ips variable in the root node_group.tf, it’s not possible to pass this value correctly to the self-managed-node-group and _user_data modules. This causes the additional_cluster_dns_ips setting to be silently ignored. This patch ensures that the value can be propagated properly through the module chain. Thanks! |
|
what OS/AMI are you using? |
I’m using the BOTTLEROCKET_x86_64 AMI type in the node group configuration, as defined in the example: |
bryantbiggs
changed the title
additional_cluster_dns_ips is passed through from root module
bryantbiggs
merged commit 7a83b1b
into
terraform-aws-modules:master
## [20.36.1](v20.36.0...v20.36.1) (2025-06-09) ### Bug Fixes * Ensure `additional_cluster_dns_ips` is passed through from root module ([#3376](#3376)) ([7a83b1b](7a83b1b))
|
This PR is included in version 20.36.1 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Add missing
additional_cluster_dns_ipsvariable definition and forwarding in the main module filenode_group.tf.Motivation and Context
The
additional_cluster_dns_ipsvariable was not previously declared or passed in the main module (node_group.tf). This caused issues when attempting to useself.additional_cluster_dns_ipsas an input to downstream modules such asself-managed-node-groupand_user_data.By explicitly defining and forwarding the variable, this fix enables proper DNS IP customization for NodeLocal DNS and similar use cases.
Breaking Changes
No breaking changes. This PR only adds support for an optional input variable.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request