Skip to content

Conversation

TheFLHurricane
Copy link
Contributor

@TheFLHurricane TheFLHurricane commented Jul 24, 2025

Fixes inability to provide default {} encryption_config

Description

Updates how encryption_config default is defined to allow for empty {} override to turn off encryption.

Motivation and Context

Breaking Changes

No, fixes a break

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

Fixes inability to provide default {} encryption_config
@bryantbiggs bryantbiggs changed the title Update variables.tf fix: Move encryption_config default for resources out of type definition and to default variable value to allow disabling encryption Jul 24, 2025
@bryantbiggs
Copy link
Member

looks good but it will error on pre-commit - you'll need to run pre-commit run -a locally to update the variable definition in the published docs

Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@bryantbiggs bryantbiggs merged commit b37368f into terraform-aws-modules:master Jul 24, 2025
21 checks passed
antonbabenko pushed a commit that referenced this pull request Jul 24, 2025
## [21.0.2](v21.0.1...v21.0.2) (2025-07-24)

### Bug Fixes

* Move `encryption_config` default for `resources` out of type definition and to default variable value to allow disabling encryption ([#3436](#3436)) ([b37368f](b37368f))
@antonbabenko
Copy link
Member

This PR is included in version 21.0.2 🎉

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v21: encryption cannot be turned off with encryption config.
3 participants