fix: Correct variable defaults for ami_id and kubernetes_version
#3437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryantbiggs
commented
Jul 24, 2025
| type = map(object({ | ||
| create = optional(bool, true) | ||
| create = optional(bool) | ||
| kubernetes_version = optional(string) |
There was a problem hiding this comment.
removing the try() logic helped catch this missing argument
bryantbiggs
commented
Jul 24, 2025
| create_access_entry = optional(bool) | ||
| iam_role_arn = optional(string) | ||
| # Security group | ||
| vpc_security_group_ids = optional(list(string), []) |
There was a problem hiding this comment.
removing the try() logic helped catch this missing argument
antonbabenko
pushed a commit
that referenced
this pull request
Jul 24, 2025
## [21.0.3](v21.0.2...v21.0.3) (2025-07-24) ### Bug Fixes * Correct variable defaults for `ami_id` and `kubernetes_version` ([#3437](#3437)) ([8807e0b](8807e0b))
|
This PR is included in version 21.0.3 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ami_idandkubernetes_versionami_idwas not set tonullable = falsein the sub-modules, the root module would pass down anullvalue which does not meet the check requirements hereterraform-aws-eks/modules/eks-managed-node-group/main.tf
Lines 450 to 452 in 7efa43f
nullable = falsemeans the""is used which maintains the desired behavior and corrects the issueLooks like I forgot a few
try()cleanups from a previous PR - those are completed now in this PR and validatedMotivation and Context
Breaking Changes
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request