Skip to content

Conversation

bryantbiggs
Copy link
Member

@bryantbiggs bryantbiggs commented Jul 30, 2025

Description

  • Allow instance_requirements to be set in self-managed node groups
  • Correct self-managed node group test case for instance_requirements; this was incorrectly indented under another node group in the example for a few years now 😅

Motivation and Context

Breaking Changes

  • No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@bryantbiggs bryantbiggs requested a review from antonbabenko July 30, 2025 16:56
@bryantbiggs bryantbiggs merged commit 5322bf7 into master Jul 30, 2025
21 checks passed
@bryantbiggs bryantbiggs deleted the fix/instance-requirements branch July 30, 2025 17:04
antonbabenko pushed a commit that referenced this pull request Jul 30, 2025
## [21.0.6](v21.0.5...v21.0.6) (2025-07-30)

### Bug Fixes

* Allow `instance_requirements` to be set in self-managed node groups ([#3455](#3455)) ([5322bf7](5322bf7))
@antonbabenko
Copy link
Member

This PR is included in version 21.0.6 🎉

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot unset instance_type in place of instance_requirements
2 participants