Skip to content

Conversation

bryantbiggs
Copy link
Member

Description

  • Allow disabling instance refresh on self-managed node groups (part deux). Maintains current default behavior; users can disable with instance_refresh = {}

Motivation and Context

Breaking Changes

  • No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@bryantbiggs bryantbiggs merged commit ca8f37e into master Aug 13, 2025
20 checks passed
antonbabenko pushed a commit that referenced this pull request Aug 13, 2025
## [21.0.9](v21.0.8...v21.0.9) (2025-08-13)

### Bug Fixes

* Allow disabling instance refresh on self-managed node groups (part deux) ([#3478](#3478)) ([ca8f37e](ca8f37e))
@antonbabenko
Copy link
Member

This PR is included in version 21.0.9 🎉

@bryantbiggs bryantbiggs deleted the fix/instance-refresh branch August 13, 2025 15:28
@cpanixperi
Copy link

Hi,
I guess this is something broke on my prod system.
I am not pinning any version for terraform-aws-modules. It was working fine till y'day . But today I see this error.
Downloading registry.terraform.io/terraform-aws-modules/iam/aws 6.0.0 for my_cluster.eks.iam_eks_role...

  • my_cluster.eks.iam_eks_role in .terraform/modules/my_cluster.eks.iam_eks_role/modules/iam-role-for-service-accounts-eks

    │ Error: Unreadable module directory

    │ The directory
    │ .terraform/modules/my_cluster.eks.iam_eks_role/modules/iam-role-for-service-accounts-eks
    │ could not be read. This is a bug in Terraform and should be reported.

@bryantbiggs
Copy link
Member Author

Hi, I guess this is something broke on my prod system. I am not pinning any version for terraform-aws-modules. It was working fine till y'day . But today I see this error. Downloading registry.terraform.io/terraform-aws-modules/iam/aws 6.0.0 for my_cluster.eks.iam_eks_role...

* my_cluster.eks.iam_eks_role in .terraform/modules/my_cluster.eks.iam_eks_role/modules/iam-role-for-service-accounts-eks
  ╷
  │ Error: Unreadable module directory
  │
  │ The directory
  │ .terraform/modules/my_cluster.eks.iam_eks_role/modules/iam-role-for-service-accounts-eks
  │ could not be read. This is a bug in Terraform and should be reported.
  1. The module shown in your error is the IAM module, not this module (EKS)
  2. It broke because you are not specifying a version at all - thats always going to be painful but completely within your control
  3. None of it is related to this change here

@terraform-aws-modules terraform-aws-modules locked as off-topic and limited conversation to collaborators Aug 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot disable instance_refresh in self-managed-node-group since v21.x
3 participants