Skip to content

Conversation

bryantbiggs
Copy link
Member

Description

  • Remediate type mismatch for EFA interfaces and ensure correct (local) definition is used

Motivation and Context

Breaking Changes

  • No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookg good, but rather weird to nullify values.

@bryantbiggs
Copy link
Member Author

ya its really dumb - https://discuss.hashicorp.com/t/overcoming-inconsistent-types-in-ternary/46762

We have to match the form fully (per the thread linked above) so that the shape on both sides of the ternary are the "same" ¯\_(ツ)_/¯

@bryantbiggs bryantbiggs merged commit 3959b65 into master Aug 24, 2025
20 checks passed
antonbabenko pushed a commit that referenced this pull request Aug 24, 2025
## [21.1.2](v21.1.1...v21.1.2) (2025-08-24)

### Bug Fixes

* Remediate type mismatch for EFA interfaces and ensure correct (local) definition is used ([#3491](#3491)) ([3959b65](3959b65))
@antonbabenko
Copy link
Member

This PR is included in version 21.1.2 🎉

@bryantbiggs bryantbiggs deleted the fix/efa branch August 24, 2025 18:09
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants