Skip to content

fix: Ensure module created security group is included on any network interfaces created #3493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 25, 2025
+1 −1
Merged

fix: Ensure module created security group is included on any network interfaces created #3493

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c843be
fix(module): wrong variable name in eks-managed-node-group
kamontat Aug 25, 2025
822a92d
Update modules/eks-managed-node-group/main.tf
bryantbiggs Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions modules/eks-managed-node-group/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@ resource "aws_launch_template" "this" {
primary_ipv6 = network_interfaces.value.primary_ipv6
private_ip_address = network_interfaces.value.private_ip_address
# Ref: https://github.com/hashicorp/terraform-provider-aws/issues/4570
security_groups = compact(concat(network_interfaces.value.security_groups, var.vpc_security_group_ids))
security_groups = compact(concat(network_interfaces.value.security_groups, local.security_group_ids))
# Set on EKS managed node group, will fail if set here
# https://docs.aws.amazon.com/eks/latest/userguide/launch-templates.html#launch-template-basics
# subnet_id = try(network_interfaces.value.subnet_id, null)
Expand Down Expand Up @@ -360,7 +360,7 @@ resource "aws_launch_template" "this" {

update_default_version = var.update_launch_template_default_version
user_data = module.user_data.user_data
vpc_security_group_ids = length(local.network_interfaces) > 0 ? [] : local.security_group_ids
vpc_security_group_ids = length(local.network_interfaces) > 0 ? [] : var.vpc_security_group_ids

tags = merge(
var.tags,
Expand Down
Loading