-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
miss push #3507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
agladboy
wants to merge
64
commits into
terraform-aws-modules:master
from
BetterWorks:add-fsx-supports
Closed
miss push #3507
agladboy
wants to merge
64
commits into
terraform-aws-modules:master
from
BetterWorks:add-fsx-supports
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added IAM Role Service accounts module to help with creating the iam roles.
* Updates to managed node groups config to include support for spot instances * Udpates to node groups config * Fixing vars * Removing instance_type var from node creation, upgrading provider to >=3.19 to support spot * Fixing typo * Updating comment * Updating to allow specifying disk_size (may move to launch template) * Apparently disk_size was already there * Fixing typo * Rearranging some things for readability * Adding initial config for node group launch templates * Fixing security group lookup in launch template * Fixing security group lookup in launch template * Fixing security group lookup in launch template * Adding missing key to worker group defaults * Disabling random pet * Adding disk encryption to node group launch template * Updating Name labels * Adding dynamic launch_template config to node groups * Adding dependency on launch templation creation to node group creation * Adding dependency on launch templation creation to node group creation * Adding dependency on launch templation creation to node group creation * Adding dependency on launch templation creation to node group creation * Adding dependency on launch templation creation to node group creation * Adding dependency on launch templation creation to node group creation * Adding dependency on launch templation creation to node group creation * Adding dependency on launch templation creation to node group creation * Adding dependency on launch templation creation to node group creation * Adding dependency on launch templation creation to node group creation * Adding dependency on launch templation creation to node group creation * Adding dependency on launch templation creation to node group creation * Adding dependency on launch templation creation to node group creation * Adding dependency on launch templation creation to node group creation * Adding dependency on launch templation creation to node group creation * Adding dependency on launch templation creation to node group creation * Adding dependency on launch templation creation to node group creation * Adding dependency on launch templation creation to node group creation * Cleaning up launch template config * Cleaning up launch template config * Cleaning up launch template config * Cleaning up launch template config * Cleaning up launch template config * Cleaning up launch template config * Cleaning up launch template config * Cleaning up launch template config * Cleaning up launch template config * Cleaning up launch template config * Cleaning up launch template config * Cleaning up launch template config * Cleaning up launch template config * Cleaning up launch template config * Re-enabling node group output * Adding variable, updating cluster config to set the cluster update timeout * Re-enabling node group output * Updating node groups to use specified instance profile * Updating node groups to use specified instance profile * Updating node groups to use specified instance profile * Updating node groups to use specified instance profile * Updating node groups to use specified instance profile * Updating node groups to use specified instance profile * Updating node groups to use specified instance profile * Updating launch templates to use count instead of for each * Updating launch templates to use count instead of for each * Reverting to for each * Reverting to for each * Fixing var that is being overwritten * Fixing var that is being overwritten * Fixing var that is being overwritten * Temp removing ignore_changes * Reenabling ignore_changes for desired_size * Removing unneeded file Co-authored-by: Justin Ross <[email protected]> Co-authored-by: Justin Ross <[email protected]>
Adding config for eks cluster addons
* fix: removing asg * fix: removing old asg's * fix: adding force_update_version * fix: adding iam back in * fix: iam * fix: trying to get everything to work * fix; retrying Co-authored-by: Henry He <[email protected]>
* cleaning up old workers * removing old references * adding Iam roles * fix: hard coding creation of templates * fix: passing default through and using it on node groups Co-authored-by: Henry He <[email protected]>
increasing timeouts since updates can take a considerable amount of time Co-authored-by: Henry He <[email protected]>
* fix: adding custom sg rules for egresses * fix: cidr blocks * tcp * ignore changes * putting changes back in
* fix: removing windows images * fix: list to tolist * fix: outputing iam and sgs from cluster * fix: map to tomap * fix: senisitive information labels
adding extra roles needed for Karpenter
fix: hop limit
Encryption
chore: switching cluster to branch for testing
* chore: add config to allow scaling of coredns pods * chore: hard-coding replicas for now * fix: typos
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Breaking Changes
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull request