-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat: Update Karpenter controller policy and permissions to match upstream project #3510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update Karpenter controller policy and permissions to match upstream project #3510
Conversation
Signed-off-by: Erez Zarum <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there's been a few other changes so added those in to re-align with upstream. Thank you!
## [21.2.0](v21.1.5...v21.2.0) (2025-09-11) ### Features * Update Karpenter controller policy and permissions to match upstream project ([#3510](#3510)) ([131db39](131db39))
This PR is included in version 21.2.0 🎉 |
Hi @bryantbiggs! Not sure why, but I see that |
modules/karpenter/policy.tf
Outdated
sid = "AllowRegionalReadActions" | ||
resources = ["*"] | ||
actions = [ | ||
"ec2:DescribeCapacityReservations", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bryantbiggs Why was this permission removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davivcgarcia in the time its taken you to post 3+ different messages you could have simply opened a PR to fix this error - try to put a little effort in would ya
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for that, but I didn't know if that was in purpose or not. :-(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clearly not - we want to align with the upstream policy but there was an error made in aligning the permissions
Description
Karpenter supports for Capacity Reservation introduce a new IAM permissions, a previous PR resolved this but was missing the
ec2:DescribeCapacityReservations
permission.Motivation and Context
To allow users use Karpenter with Capacity Reservation
Changes from the following upstream PRs:
Breaking Changes
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull request