mention change of behavior for encryption_config when upgrading to v21.
#3531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryantbiggs
reviewed
Sep 25, 2025
| - `addons.most_recent` is now set to `true` by default (was `false`). | ||
| - `cluster_identity_providers.issuer_url` is now required to be set by users; the prior incorrect default has been removed. See https://github.com/terraform-aws-modules/terraform-aws-eks/pull/3055 and https://github.com/kubernetes/kubernetes/pull/123561 for more details. | ||
| - The OIDC issuer URL for IAM roles for service accounts (IRSA) has been changed to use the new dual stack`oidc-eks` endpoint instead of `oidc.eks`. This is to align with https://github.com/aws/containers-roadmap/issues/2038#issuecomment-2278450601 | ||
| - `encryption_config` (formerly `cluster_encryption_config`) is now enabled by default. If you are migrating a cluster from v20 that used the previously disabled default and wish to preserve this same behavior, you will need to explicitly set this variable to `null`. If using the new behavior is preferred when migrating you will additionally need to supply a value for the `encryption_config` [key_arn](../variables.tf#L174). |
There was a problem hiding this comment.
is now enabled by default.
Should not be added here - it has been enabled by default since v19.0
Suggested change
| - `encryption_config` (formerly `cluster_encryption_config`) is now enabled by default. If you are migrating a cluster from v20 that used the previously disabled default and wish to preserve this same behavior, you will need to explicitly set this variable to `null`. If using the new behavior is preferred when migrating you will additionally need to supply a value for the `encryption_config` [key_arn](../variables.tf#L174). | |
| - With the changes to the variable type definition for `encryption_config` (formerly `cluster_encryption_config`), if you wish to disable secret encryption with a custom KMS key you should set `encryption_config = null` (In `v20.x`, you would previously have set `encryption_config = {}` to achieve the same outcome) |
|
You need to be careful with the description - it is not possible to disable secret encryption on EKS clusters anymore. This is a change that EKS made somewhat recently https://docs.aws.amazon.com/eks/latest/userguide/envelope-encryption.html So you are not disabling encryption - you are opting out of encryption with a customer managed KMS key. Secrets will still be encrypted, albeit with a key created/managed by AWS |
|
alright - well added the note here 2ad67a5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
adding notes about the change in behavior for
encryption_config(formerlycluster_encryption_config) in the v21 upgrade guide.Motivation and Context
previously this was disabled by default and has changed to be enabled by default, which will cause
planfailures when trying to migrate existing clusters from v20 to v21.related issues:
related PR discussions:
Breaking Changes
none. just adding a line to the 21 upgrade guide.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request(not trying to ignore standards but this only adds to a markdown file.)