-
Notifications
You must be signed in to change notification settings - Fork 168
fix: Allow Pipes with Kinesis Targets #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Allow Pipes with Kinesis Targets #143
Conversation
…r invoking the function
This PR has been automatically marked as stale because it has been open 30 days |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Lambda fix plus another
Added the changes outlined in the #144 as requested. Thanks! |
## [3.14.2](v3.14.1...v3.14.2) (2025-01-10) ### Bug Fixes * Allow Pipes with Kinesis Targets ([#143](#143)) ([b4b29bf](b4b29bf))
This PR is included in version 3.14.2 🎉 |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Add a dynamic block to the
var.pipes[].target_parameters
forkinesis_stream_parameters.partition_key
.Motivation and Context
Before the
partition_key
was not pulled in and therefore the create of the pipe always failed as it is a required field for creating a pipe with a kinesis target.Breaking Changes
Additive so no expected breakage.
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull request