Skip to content

Conversation

soisyourface
Copy link
Contributor

@soisyourface soisyourface commented Dec 6, 2024

Description

Add a dynamic block to the var.pipes[].target_parameters for kinesis_stream_parameters.partition_key.

Motivation and Context

module "doro-eventbridge" {
  source = "./modules/terraform-aws-eventbridge"
  # source   = "terraform-aws-modules/eventbridge/aws"
  # version  = "3.13.0"
  bus_name = "doro"

  pipes = {
    doro_test = {
      source = "${aws_kinesis_stream.streamA.arn}"
      target = "${aws_kinesis_stream.streamO.arn}"

      source_parameters = {
        kinesis_stream_parameters = {
          starting_position = "LATEST"
        }
      }
      target_parameters = {
        kinesis_stream_parameters = {
          partition_key = "$.deviceId"
        }
      }
    }
  }
}

Before the partition_key was not pulled in and therefore the create of the pipe always failed as it is a required field for creating a pipe with a kinesis target.

Breaking Changes

Additive so no expected breakage.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@soisyourface soisyourface changed the title Allow Pipes with Kinesis Targets fix: Allow Pipes with Kinesis Targets Dec 6, 2024
@soisyourface soisyourface mentioned this pull request Dec 10, 2024
1 task
Copy link

github-actions bot commented Jan 6, 2025

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Jan 6, 2025
Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot removed the stale label Jan 9, 2025
@soisyourface
Copy link
Contributor Author

Added the changes outlined in the #144 as requested.
This should be ready to go.

Thanks!

@antonbabenko antonbabenko merged commit b4b29bf into terraform-aws-modules:master Jan 10, 2025
2 checks passed
antonbabenko pushed a commit that referenced this pull request Jan 10, 2025
## [3.14.2](v3.14.1...v3.14.2) (2025-01-10)

### Bug Fixes

* Allow Pipes with Kinesis Targets ([#143](#143)) ([b4b29bf](b4b29bf))
@antonbabenko
Copy link
Member

This PR is included in version 3.14.2 🎉

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants