feat: Added dynamic block for managed_streaming_kafka_parameters #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As observed managed_streaming_kafka_parameters was missing from source parameters for aws_pipes_pipe resource in the module.
praveen-kotak287676
changed the title
praveen-kotak287676
changed the title
praveen-kotak287676
changed the title
antonbabenko
approved these changes
Jan 7, 2025
antonbabenko
merged commit 7621d52
into
terraform-aws-modules:master
2 of 5 checks passed
antonbabenko
pushed a commit
that referenced
this pull request
Jan 7, 2025
## [3.14.0](v3.13.0...v3.14.0) (2025-01-07) ### Features * Added dynamic block for managed_streaming_kafka_parameters ([#148](#148)) ([7621d52](7621d52))
|
This PR is included in version 3.14.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As observed managed_streaming_kafka_parameters was missing from source parameters for aws_pipes_pipe resource in the module.
Motivation and Context
For serving the events from MSK topic to API destination via eventbridge pipe.
Breaking Changes
NO breaking changes , only add to support new source_parameter for MSK kafka.
Because it is necessary and valid source_parameter in the official resource for configuring managed_streaming_kafka_parameters pipes.
Supported Reference : [Link](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/pipes_pipe#managed_streaming_kafka_parameters-1
How Has This Been Tested?
We are using in our project and configuring the pipes from MSK to API Destination , already tested it is up and running no breaking changes occurred.