fix: Use externally created eventbus for event archive when create_bus is set to false
#176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuntac
force-pushed
the
feat-use-event-bus-data-for-event-archives
branch
2 times, most recently
from
8bd6b6b to
11f6db8
Compare
yuntac
changed the title
yuntac
changed the title
|
This PR has been automatically marked as stale because it has been open 30 days |
|
This PR has been automatically marked as stale because it has been open 30 days |
bryantbiggs
reviewed
Oct 4, 2025
|
|
||
| name = lookup(each.value, "name", each.key) | ||
| event_source_arn = try(each.value["event_source_arn"], aws_cloudwatch_event_bus.this[0].arn) | ||
| event_source_arn = try(each.value["event_source_arn"], var.create_bus ? aws_cloudwatch_event_bus.this[0].arn : data.aws_cloudwatch_event_bus.this[0].arn) |
There was a problem hiding this comment.
this looks like a valid change, can we remove all the other changes?
bryantbiggs
force-pushed
the
feat-use-event-bus-data-for-event-archives
branch
from
11f6db8 to
65202cc
Compare
bryantbiggs
changed the title
create_bus is set to false
bryantbiggs
changed the title
create_bus is set to falsecreate_bus is set to false
bryantbiggs
approved these changes
Oct 6, 2025
antonbabenko
pushed a commit
that referenced
this pull request
Oct 6, 2025
## [4.2.1](v4.2.0...v4.2.1) (2025-10-06) ### Bug Fixes * Use externally created eventbus for event archive when `create_bus` is set to `false` ([#176](#176)) ([e30c402](e30c402))
|
This PR is included in version 4.2.1 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow to use eventbus data for event archive when create_bus is set to false
Motivation and Context
In case of create_bus is set to false, we can't use the aws_cloudwatch_event_bus data in aws_cloudwatch_event_archive resource. we have to set a new data in root module and use it in archives.event_source_arn. This feature allow to directly use the data of the child module if it's desired
Breaking Changes
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request