fix: Correct iam-group variable name mis-spelling

[bryantbiggs]

Description

• Correct iam-group variable name mis-spelling

Motivation and Context

• Resolves A typo in group's module variables #608

Breaking Changes

• No

How Has This Been Tested?

• I have updated at least one of the examples/* to demonstrate and validate my change(s)
• I have tested and validated these changes using one or more of the provided examples/* projects

• I have executed pre-commit run -a on my pull request

[antonbabenko]

This PR is included in version 6.2.1 🎉

[mohag]

Shouldn't there be some compatibility variables (ideally emitting warnings) for breaking changes, especially in patch releases? (I just changed everything to the misspelled version and now need to change it back)

[bryantbiggs]

If you can tell us how to emit warnings, we'll try to do it

But Terraform doesn't support this

[mohag]

Yep, unfortunately it seems not (I posted before I finished checking - I opened the docs, but forgot to check before submitting)

Errors are easy, warnings not.

This is at least mostly a search and replace away (and then updating version constraints to >= 6.2.1 to ensure that everyone upgrades.

(I was a bit frustrated. The groups were easy to migrate to v6 (and then I was surprised by this breakage, which I kind of expected at some point, since the same typo was fixed previously), the roles I mostly constrained to < 6.0 for now) (The updates makes sense, but migration, for the iam-roles at least, are complex) (and I have a provider v6 region addition PR on another repo on this org which has been eerily quiet)

Terraform can do with more options for making module upgrades easier.

[bryantbiggs]

Yep, unfortunately it seems not (I posted before I finished checking - I opened the docs, but forgot to check before submitting)

Errors are easy, warnings not.

This is at least mostly a search and replace away (and then updating version constraints to >= 6.2.1 to ensure that everyone upgrades.

(I was a bit frustrated. The groups were easy to migrate to v6 (and then I was surprised by this breakage, which I kind of expected at some point, since the same typo was fixed previously), the roles I mostly constrained to < 6.0 for now) (The updates makes sense, but migration, for the iam-roles at least, are complex) (and I have a provider v6 region addition PR on another repo on this org which has been eerily quiet)

Terraform can do with more options for making module upgrades easier.

because its a breaking change, and if we are going to make a breaking change, we'll look to do as much as possible to move the module forward for users -> terraform-aws-modules/terraform-aws-transit-gateway#113. it doesn't make sense to make many small breaking changes which end up causing users frustration