Skip to content

fix: Update aws_sns_topic_subscription endpoint to use qualified arn #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2024
Merged

fix: Update aws_sns_topic_subscription endpoint to use qualified arn #231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ See the [functions](https://github.com/terraform-aws-modules/terraform-aws-notif

| Name | Source | Version |
|------|--------|---------|
| <a name="module_lambda"></a> [lambda](#module\_lambda) | terraform-aws-modules/lambda/aws | 3.2.0 |
| <a name="module_lambda"></a> [lambda](#module\_lambda) | terraform-aws-modules/lambda/aws | 6.8.0 |

## Resources

Expand Down
4 changes: 2 additions & 2 deletions main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,14 +73,14 @@ resource "aws_sns_topic_subscription" "sns_notify_slack" {

topic_arn = local.sns_topic_arn
protocol = "lambda"
endpoint = module.lambda.lambda_function_arn
endpoint = module.lambda.lambda_function_qualified_arn
filter_policy = var.subscription_filter_policy
filter_policy_scope = var.subscription_filter_policy_scope
}

module "lambda" {
source = "terraform-aws-modules/lambda/aws"
version = "3.2.0"
version = "6.8.0"

create = var.create

Expand Down