Skip to content

Conversation

srouaix
Copy link
Contributor

@srouaix srouaix commented Sep 1, 2025

Description

When retrieving subnets via the aws_subnet datasource, we must specify the region to get the subnets in the target region.

Motivation and Context

Data such as subnets are regionalized. We must ensure that we retrieve the subnets in the region configured in the region variable; otherwise, the provider's region is used, which is incorrect.

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@srouaix srouaix changed the title fix: add region for subnets recovery Fix: add region for subnets recovery Sep 1, 2025
@srouaix srouaix changed the title Fix: add region for subnets recovery fix: add region for subnets recovery Sep 1, 2025
@srouaix srouaix changed the title fix: add region for subnets recovery fix: Add region for subnets recovery Sep 1, 2025
@srouaix srouaix force-pushed the fix/missing-region-data-source-subnets branch from 3b459f7 to 1d6e764 Compare September 1, 2025 10:17
@srouaix srouaix force-pushed the fix/missing-region-data-source-subnets branch from 1d6e764 to dc82b6d Compare September 1, 2025 10:27
@bryantbiggs bryantbiggs merged commit e019891 into terraform-aws-modules:master Sep 1, 2025
8 checks passed
antonbabenko pushed a commit that referenced this pull request Sep 1, 2025
## [2.1.1](v2.1.0...v2.1.1) (2025-09-01)

### Bug Fixes

* Add region for subnets recovery ([#44](#44)) ([e019891](e019891))
@antonbabenko
Copy link
Member

This PR is included in version 2.1.1 🎉

Copy link

github-actions bot commented Oct 2, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants