docs: Update variable engine description #480
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Knapsack44
changed the title
Knapsack44
changed the title
Knapsack44
changed the title
|
This PR has been automatically marked as stale because it has been open 30 days |
|
bump, to prevent staling |
|
This PR has been automatically marked as stale because it has been open 30 days |
|
This PR was automatically closed because of stale in 10 days |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The README.md mentions as possible values for engine only Aurora derivates. But since the terraform documentations also mentions
mysqlandpostgresas possible values (Souce) I've added both to the variables.tf description.Motivation and Context
It will update and reflect the current working state especially because it's already used in the examples.
Breaking Changes
No breaking changes.
How Has This Been Tested?
I have updated at least one of the
examples/*to demonstrate and validate my change(s)see https://github.com/terraform-aws-modules/terraform-aws-rds-aurora/tree/v9.11.0/examples/multi-az
I have tested and validated these changes using one or more of the provided
examples/*projectspre-commit run -aon my pull request