fix: Rearranged maps in merge in main.tf:340 for rds aurora security group tags #494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chandu-rrsch
changed the title
chandu-rrsch
changed the title
chandu-rrsch
changed the title
chandu-rrsch
changed the title
bryantbiggs
reviewed
Mar 27, 2025
| description = coalesce(var.security_group_description, "Control traffic to/from RDS Aurora ${var.name}") | ||
|
|
||
| tags = merge(var.tags, var.security_group_tags, { Name = local.security_group_name }) | ||
| tags = merge(var.tags, { Name = local.security_group_name }, var.security_group_tags) |
There was a problem hiding this comment.
this is incorrect - it is correct as its written today
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change lets the user set a custom name tag for aurora security group in
tagsas it is being overridden by the security group name defined. The change is in the order of the maps in the security group tags.Motivation and Context
This change lets module user to set custom name tag for aurora security group instead of the security group name as the value for name tag.
Issue: #492
Breaking Changes
The current changes renames existing Name tag which does not break any existing infrastructure.
How Has This Been Tested?
[ ✅ ] I have tested and validated these changes using one or more of the provided
examples/*projects[ ✅ ] I have executed
pre-commit run -aon my pull request