fix: remove unsupported s3Import feature name #503
Conversation
As described here terraform-aws-modules#273, s3Import is not accepted any more. I have tested with an empty string and it works.
examples/s3-import/main.tf
Outdated
| s3_import = { | ||
| role_arn = aws_iam_role.s3_import.arn | ||
| feature_name = "s3Import" | ||
| feature_name = "" |
There was a problem hiding this comment.
so this looks like another silent AWS change unfortunately
making this change here is not correct. after spending some time digging into this, here is what I found:
- The API has changed from requiring a value to now not requiring a value - this should be corrected/relaxed in the AWS provider first. Once that is corrected, we can update this so that users do not need to pass empty strings (thats just weird).
- There doesn't appear to be ANY feature names supported for MySQL anymore:
-
aws rds describe-db-engine-versions --engine mysql --engine-version 5.7 --query 'DBEngineVersions[*].SupportedFeatureNames'returns
[ [], [], [], [], [], [] ] -
aws rds describe-db-engine-versions --engine mysql --engine-version 8.0 --query 'DBEngineVersions[*].SupportedFeatureNames'returns
[ [], [], [], [], [], [], [], [], [], [] ]
- After looking at https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/AuroraMySQL.Integrating.LoadFromS3.html, it appears that this example is no longer valid, or perhaps, not the recommend route for importing. Looking at the docs today, it looks like users should execute the import via SQL instead of via the AWS RDS API - is that correct?
|
I have removed that code block entirely because I had timeout issues with the role being assigned to the RDS instance. It went through, but I want to give another test to see whether everything is in order or not. In the meantime let me know if this looks like a better fix in your opinion. |
|
This PR has been automatically marked as stale because it has been open 30 days |
|
This PR was automatically closed because of stale in 10 days |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
2 participants
Description
As described here #273, s3Import is not accepted any more. I have tested with an empty string and it works.