Skip to content

fix: remove unsupported s3Import feature name #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix: remove unsupported s3Import feature name #503

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04ff378
fix: remove unsupported s3Import feature name
meniluca May 14, 2025
503ba45
fix: removing unused role definition
meniluca May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/s3-import/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ module "aurora" {
iam_roles = {
s3_import = {
role_arn = aws_iam_role.s3_import.arn
feature_name = "s3Import"
feature_name = ""
Copy link
Member

@bryantbiggs bryantbiggs May 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this looks like another silent AWS change unfortunately

making this change here is not correct. after spending some time digging into this, here is what I found:

  1. The API has changed from requiring a value to now not requiring a value - this should be corrected/relaxed in the AWS provider first. Once that is corrected, we can update this so that users do not need to pass empty strings (thats just weird).
  2. There doesn't appear to be ANY feature names supported for MySQL anymore:

  • aws rds describe-db-engine-versions --engine mysql --engine-version 5.7 --query 'DBEngineVersions[*].SupportedFeatureNames'

    returns

    [
  [],
  [],
  [],
  [],
  [],
  []
]

  • aws rds describe-db-engine-versions --engine mysql --engine-version 8.0 --query 'DBEngineVersions[*].SupportedFeatureNames'

    returns

    [
  [],
  [],
  [],
  [],
  [],
  [],
  [],
  [],
  [],
  []
]
  1. After looking at https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/AuroraMySQL.Integrating.LoadFromS3.html, it appears that this example is no longer valid, or perhaps, not the recommend route for importing. Looking at the docs today, it looks like users should execute the import via SQL instead of via the AWS RDS API - is that correct?

}
}

Expand Down
Loading