feat: Add create_before_destroy to Aurora DB instance resource
#506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhenry82
changed the title
bryantbiggs
changed the title
create_before_destroy to Aurora DB instance resource
bryantbiggs
approved these changes
Jun 4, 2025
bryantbiggs
merged commit 6468f81
into
terraform-aws-modules:master
14 of 15 checks passed
antonbabenko
pushed a commit
that referenced
this pull request
Jun 4, 2025
## [9.14.0](v9.13.0...v9.14.0) (2025-06-04) ### Features * Add `create_before_destroy` to Aurora DB instance resource ([#506](#506)) ([6468f81](6468f81))
|
This PR is included in version 9.14.0 🎉 |
1 task
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a
create_before_destroylifecycle block to theaws_rds_cluster_instanceresources.Motivation and Context
This improves time to recover in the (uncommon) case where the DB instances have to be replaced, for example to change their identifier or network configuration. We have observed that it can take nearly 10 minutes to destroy an Aurora instance. And then a similar time to create its replacement. During this time the DB is inaccessible. By using
create_before_destroy, there is only a small interruption while one of the new instances is promoted to the Writer role. Which seems to typically take less than 30 seconds.Breaking Changes
N/A
How Has This Been Tested?
pre-commit run -aon my pull requestThere is nothing to change in the
examples, everything is internal to the code of the module.