Skip to content

fix: Correct service principal to rds.amazonaws.com (incl China) #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 22, 2025
Merged

fix: Correct service principal to rds.amazonaws.com (incl China) #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
c93848c
fix: Correct service principal to rds.amazonaws.com since ints univer…
vladislav-orlovskiy May 14, 2025
1fc2397
Update main.tf
vladislav-orlovskiy May 15, 2025
7217651
fix: replace string service principal with datasource to get rid of m…
vladislav-orlovskiy May 15, 2025
2697d41
fix: add count to service principal resource.
vladislav-orlovskiy May 15, 2025
324e2db
fix: add count to service principal resource.
vladislav-orlovskiy May 15, 2025
3b0ef69
fix: replace id with suffix.
vladislav-orlovskiy May 15, 2025
6ae3759
fix: replace id with suffix.
vladislav-orlovskiy May 15, 2025
131b35f
fix: replace id with name
vladislav-orlovskiy May 19, 2025
9744770
Apply suggestions from code review
antonbabenko May 22, 2025
8da4f2d
Update main.tf
antonbabenko May 22, 2025
c6294ed
Fixed docs
antonbabenko May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ No modules.
| [aws_iam_policy_document.this](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/iam_policy_document) | data source |
| [aws_partition.current](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/partition) | data source |
| [aws_region.current](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/region) | data source |
| [aws_service_principal.rds](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/service_principal) | data source |

## Inputs

Expand Down
7 changes: 6 additions & 1 deletion main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,12 @@ locals {

data "aws_region" "current" {}
data "aws_partition" "current" {}
data "aws_service_principal" "rds" {
count = var.create && var.create_iam_role ? 1 : 0

service_name = "rds"
region = data.aws_region.current.name
}
################################################################################
# RDS Proxy
################################################################################
Expand Down Expand Up @@ -111,7 +116,7 @@ data "aws_iam_policy_document" "assume_role" {

principals {
type = "Service"
identifiers = ["rds.${data.aws_partition.current.dns_suffix}"]
identifiers = [data.aws_service_principal.rds[0].name]
}
}
}
Expand Down