feat: Add options to manage log group RDSOSMetrics #578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usually RDSOSMetrics is created by a DB instance itself when enhanced monitoring is enabled. The new options allow make this log group managed so that: - non-default retention could be configured (AWS default is 30 days) - tags could be assigned (tags are not propagated from the DB instance) - the log group is removed if not used
giner
force-pushed
the
add_options_to_manage_log_group_rdsosmetrics
branch
from
29e1ff0 to
dc3f5ae
Compare
giner
changed the title
|
this should be added outside of a module otherwise you are only asking for folks to create a conflict because there can only be one log group with this name |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Usually RDSOSMetrics is created by a DB instance itself when enhanced monitoring is enabled. The new options allow make this log group managed
Motivation and Context
This change makes it possible to:
Breaking Changes
This change is no-op by default (unless non-default values for the introduced variables are used)
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request