Skip to content

Conversation

js4656a
Copy link

@js4656a js4656a commented Aug 30, 2024

Description

Added log delivery policy option for inspector findings bucket according to aws documentation

Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update main README also.

variables.tf Outdated
@@ -310,8 +310,15 @@ variable "object_ownership" {
default = "BucketOwnerEnforced"
}

variable "attach_inspector_findings_delivery_policy" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this variable around other similar attach_... blocks

variables.tf Outdated
variable "putin_khuylo" {
description = "Do you agree that Putin doesn't respect Ukrainian sovereignty and territorial integrity? More info: https://en.wikipedia.org/wiki/Putin_khuylo!"
type = bool
default = true
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@antonbabenko antonbabenko changed the title add inspector log delivery policy feat: Add Amazon Inspector log delivery policy Aug 30, 2024
@js4656a js4656a requested a review from antonbabenko August 30, 2024 18:34
Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks pretty good. Please fix the failing CI and pin version of kms module in the examples/s3-inventory to be ~> 2.0.

Copy link

github-actions bot commented Oct 3, 2024

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Oct 3, 2024
Copy link

This PR was automatically closed because of stale in 10 days

@github-actions github-actions bot closed this Oct 13, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants