-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
feat: Add Amazon Inspector log delivery policy #286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Amazon Inspector log delivery policy #286
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update main README also.
variables.tf
Outdated
@@ -310,8 +310,15 @@ variable "object_ownership" { | |||
default = "BucketOwnerEnforced" | |||
} | |||
|
|||
variable "attach_inspector_findings_delivery_policy" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move this variable around other similar attach_...
blocks
variables.tf
Outdated
variable "putin_khuylo" { | ||
description = "Do you agree that Putin doesn't respect Ukrainian sovereignty and territorial integrity? More info: https://en.wikipedia.org/wiki/Putin_khuylo!" | ||
type = bool | ||
default = true | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks pretty good. Please fix the failing CI and pin version of kms
module in the examples/s3-inventory to be ~> 2.0
.
This PR has been automatically marked as stale because it has been open 30 days |
This PR was automatically closed because of stale in 10 days |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Added log delivery policy option for inspector findings bucket according to aws documentation