Skip to content

fix: Remove ACL in analytics, inventory, and replication examples #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2024
Merged

fix: Remove ACL in analytics, inventory, and replication examples #292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions examples/s3-analytics/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ module "analytics_configuration_bucket" {
attach_analytics_destination_policy = true
attach_policy = true
analytics_self_source_destination = true
acl = "private" # "acl" conflicts with "grant" and "owner"

versioning = {
status = true
Expand Down Expand Up @@ -77,7 +76,6 @@ module "analytics_destination_bucket" {
source = "../../"

bucket = "analytics-destination-${random_pet.this.id}"
acl = "private" # "acl" conflicts with "grant" and "owner"
force_destroy = true
attach_policy = true
attach_analytics_destination_policy = true
Expand All @@ -92,7 +90,6 @@ module "inventory_source_bucket" {
bucket = "inventory-source-${random_pet.this.id}"

force_destroy = true
acl = "private" # "acl" conflicts with "grant" and "owner"

inventory_configuration = {
destination_other = {
Expand All @@ -115,7 +112,6 @@ module "analytics_and_inventory_destination_bucket" {
source = "../../"

bucket = "analytics-and-inventory-destination-${random_pet.this.id}"
acl = "private" # "acl" conflicts with "grant" and "owner"
force_destroy = true
attach_policy = true

Expand Down
3 changes: 0 additions & 3 deletions examples/s3-inventory/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ module "multi_inventory_configurations_bucket" {
attach_policy = true
attach_inventory_destination_policy = true
inventory_self_source_destination = true
acl = "private" # "acl" conflicts with "grant" and "owner"

versioning = {
status = true
Expand Down Expand Up @@ -137,7 +136,6 @@ module "inventory_destination_bucket" {
source = "../../"

bucket = "inventory-destination-${random_pet.this.id}"
acl = "private" # "acl" conflicts with "grant" and "owner"
force_destroy = true
attach_policy = true
attach_inventory_destination_policy = true
Expand All @@ -149,6 +147,5 @@ module "inventory_source_bucket" {
source = "../../"

bucket = "inventory-source-${random_pet.this.id}"
acl = "private" # "acl" conflicts with "grant" and "owner"
force_destroy = true
}
3 changes: 0 additions & 3 deletions examples/s3-replication/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ provider "aws" {
skip_metadata_api_check = true
skip_region_validation = true
skip_credentials_validation = true
skip_requesting_account_id = true
}

locals {
Expand Down Expand Up @@ -47,7 +46,6 @@ module "replica_bucket" {
}

bucket = local.destination_bucket_name
acl = "private"

versioning = {
enabled = true
Expand All @@ -58,7 +56,6 @@ module "s3_bucket" {
source = "../../"

bucket = local.bucket_name
acl = "private"

versioning = {
enabled = true
Expand Down