Skip to content

fix: Allow null values in lifecycle configuration #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix: Allow null values in lifecycle configuration #309

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
607ec3d
fix: allow null values in lifecycle configuration
GusAntoniassi Jan 24, 2025
59feb8c
Merge branch 'master' into fix/lifecycle-rule-null-values
antonbabenko Mar 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ resource "aws_s3_bucket_lifecycle_configuration" "this" {

# Max 1 block - expiration
dynamic "expiration" {
for_each = try(flatten([rule.value.expiration]), [])
for_each = try(compact(flatten([rule.value.expiration])), [])

content {
date = try(expiration.value.date, null)
Expand All @@ -287,7 +287,7 @@ resource "aws_s3_bucket_lifecycle_configuration" "this" {

# Several blocks - transition
dynamic "transition" {
for_each = try(flatten([rule.value.transition]), [])
for_each = try(compact(flatten([rule.value.transition])), [])

content {
date = try(transition.value.date, null)
Expand All @@ -298,7 +298,7 @@ resource "aws_s3_bucket_lifecycle_configuration" "this" {

# Max 1 block - noncurrent_version_expiration
dynamic "noncurrent_version_expiration" {
for_each = try(flatten([rule.value.noncurrent_version_expiration]), [])
for_each = try(compact(flatten([rule.value.noncurrent_version_expiration])), [])

content {
newer_noncurrent_versions = try(noncurrent_version_expiration.value.newer_noncurrent_versions, null)
Expand All @@ -308,7 +308,7 @@ resource "aws_s3_bucket_lifecycle_configuration" "this" {

# Several blocks - noncurrent_version_transition
dynamic "noncurrent_version_transition" {
for_each = try(flatten([rule.value.noncurrent_version_transition]), [])
for_each = try(compact(flatten([rule.value.noncurrent_version_transition])), [])

content {
newer_noncurrent_versions = try(noncurrent_version_transition.value.newer_noncurrent_versions, null)
Expand All @@ -319,7 +319,7 @@ resource "aws_s3_bucket_lifecycle_configuration" "this" {

# Max 1 block - filter - without any key arguments or tags
dynamic "filter" {
for_each = length(try(flatten([rule.value.filter]), [])) == 0 ? [true] : []
for_each = one(try(flatten([rule.value.filter]), [])) == null ? [true] : []

content {
# prefix = ""
Expand All @@ -328,15 +328,15 @@ resource "aws_s3_bucket_lifecycle_configuration" "this" {

# Max 1 block - filter - with one key argument or a single tag
dynamic "filter" {
for_each = [for v in try(flatten([rule.value.filter]), []) : v if max(length(keys(v)), length(try(rule.value.filter.tags, rule.value.filter.tag, []))) == 1]
for_each = [for v in try(rule.value.filter == null ? [] : flatten([rule.value.filter]), []) : v if max(length(keys(v)), try(length(rule.value.filter.tags), length(rule.value.filter.tag), 0)) == 1]

content {
object_size_greater_than = try(filter.value.object_size_greater_than, null)
object_size_less_than = try(filter.value.object_size_less_than, null)
prefix = try(filter.value.prefix, null)

dynamic "tag" {
for_each = try(filter.value.tags, filter.value.tag, [])
for_each = try(coalesce(filter.value.tags, {}), coalesce(filter.value.tag, {}), [])

content {
key = tag.key
Expand All @@ -348,7 +348,7 @@ resource "aws_s3_bucket_lifecycle_configuration" "this" {

# Max 1 block - filter - with more than one key arguments or multiple tags
dynamic "filter" {
for_each = [for v in try(flatten([rule.value.filter]), []) : v if max(length(keys(v)), length(try(rule.value.filter.tags, rule.value.filter.tag, []))) > 1]
for_each = [for v in try(rule.value.filter == null ? [] : flatten([rule.value.filter]), []) : v if max(length(keys(v)), try(length(rule.value.filter.tags), length(rule.value.filter.tag), 0)) > 1]

content {
and {
Expand Down