docs: Remove acl setting from ALB/NLB example in readme file #319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove `acl` setting from ALB/NLB example in readme file
matsev
changed the title
matsev
changed the title
bryantbiggs
approved these changes
Mar 29, 2025
bryantbiggs
merged commit 6917add
into
terraform-aws-modules:master
17 of 19 checks passed
|
This PR is included in version 4.6.1 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
remove
aclsetting from ALB/NLB example in readme fileMotivation and Context
The Terraform AWS Provider Version 4 Upgrade Guide states that the
aclargument should be removed from theaws_s3_bucketresourceBreaking Changes
No. This is a change to a readme file
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)n/a change is only to a readme file
examples/*projectsn/a change is only to a readme file
pre-commit run -aon my pull requestn/a change is only to a readme file