Skip to content

feat: Support bucket metadata config #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

magreenbaum
Copy link
Member

Description

Add support for s3 bucket metadata configuration.

Motivation and Context

Breaking Changes

No.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request


# metadata configuration example
# https://docs.aws.amazon.com/AmazonS3/latest/userguide/metadata-tables-configuring.html
# create_metadata_configuration = true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have this uncommented in the example? Or does it take long time to create, or expensive which prevents us from having it here?

We will need a way to test that this feature works over time.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its not currently supported in the example region (only us-east-1, us-east-2, and us-west-2). It also creates an associated aws managed s3 table bucket where it stores journal and inventory tables associated with the general purpose bucket metadata configurations. I added additional comments regarding the region but I can create a new example for it in a supported region if preferred.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, let's keep it like this for now, and we will have to add a more complete example (with required resources) in the future.

@antonbabenko antonbabenko merged commit 2a25737 into terraform-aws-modules:master Aug 11, 2025
18 checks passed
antonbabenko pushed a commit that referenced this pull request Aug 11, 2025
## [5.4.0](v5.3.1...v5.4.0) (2025-08-11)

### Features

* Support bucket metadata config ([#351](#351)) ([2a25737](2a25737))
@antonbabenko
Copy link
Member

This PR is included in version 5.4.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants