feat: Add secret_name to outputs
#9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anilchalissery
changed the title
|
can you add the output to the example as well please https://github.com/terraform-aws-modules/terraform-aws-secrets-manager/blob/master/examples/complete/outputs.tf |
Examples output.tf updated
updated readme
|
@bryantbiggs Updated outputs.tf and readme output table as well |
bryantbiggs
approved these changes
Sep 19, 2024
bryantbiggs
changed the title
secret_name to outputs
antonbabenko
pushed a commit
that referenced
this pull request
Sep 19, 2024
## [1.3.0](v1.2.0...v1.3.0) (2024-09-19) ### Features * Add `secret_name` to outputs ([#9](#9)) ([e3d07ad](e3d07ad))
|
This PR is included in version 1.3.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
secret name will be outputted
Motivation and Context
When the AWS glue connection is created, we need the secret name. I tried with a secret ID, and neither worked.
Breaking Changes
This would print an additional output, and doesn't break anything
How Has This Been Tested?
pre-commit run -aon my pull request