-
Notifications
You must be signed in to change notification settings - Fork 286
feat(vector search): Add examples for mutate, PSC, and VPC #755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Here is the summary of changes. You are about to add 7 region tags.
This comment is generated by snippet-bot.
|
|
/gcbrun |
|
Build failures: |
…al resources still exist See hashicorp/terraform-provider-google#18729 and b/308248337#comment7 for more context
|
Thanks. Pushed two commits that should address the test failures (destroying |
|
Friendly ping on this |
|
/gcbrun |
|
/gcbrun |
|
New issue:
Due to CI (currently 4 threads, and this has five samples), all the deployed indexes in this sample must have unique names. I'll update each index to include this. |
|
/gcbrun |
|
Thanks @glasnt. The PSC tests in CI were failing with "Error waiting for Creating IndexEndpointDeployedIndex: Error code 5, message: A resource needed to create the ServiceAttachment could not be found: 'ci-tf-samples-2'. Please ensure that all input resources exist." I couldn't replicate this exact error, but the allowlist config was wrong (it should have been |
|
/gcbrun |
|
@msampathkumar Would you be able to trigger the CI build? I don't think I have proper permissions to trigger the cloud build. |
|
/gcbrun |
|
Thanks @msampathkumar ! The CI passed. Can this be merged now? |
|
Friendly ping on this |
|
/gcbrun |
|
The current error on this for index_endpoint_deploy_vpc: I'm not sure if this is an eventual consistency issue, as the same resource association (index, endpoint, deployed_index) exists in the index_endpoint_deploy sample (already in the repo). index_endpoint_deploy_vpc is failing first before index_endpoint_deploy_psc has a chance to finish, and since CI fails early I can't confirm the state of index_endpoint_deploy_psc's tests. I'm going to re-run the tests again and confirm if it's the same issue. /gcbrun |
|
The tests passed this time; not sure how to interpret that, as I'm having trouble locating the logs of the earlier failed run. My initial thought then was that the deployed endpoint hadn't been fully deleted when the terraform teardown of the endpoint itself is attempted. This is probably what you were referring to with the eventual consistency possibility mentioned in the last comment, or is that a different possible cause? |
|
/gcbrun |
|
It's possibly an eventual consistency issue, since the last tests ran. If the current rebased-changes run clean, this sample will be automerged. |
|
@ericgribkoff this has been merged! |
…-google-modules#755) * feat(vector search): Add examples for mutate, PSC, and VPC * set PSC allowlist project to name instead of number * Allow destruction of google_service_networking_connection when residual resources still exist See hashicorp/terraform-provider-google#18729 and b/308248337#comment7 for more context * Make deployed_index_ids unique * Fix PSC allowlist project ids --------- Co-authored-by: Katie McLaughlin <[email protected]>
Checklist
Readiness
Style
guide
Testing
I have performed tests described in the Contributing guide:
terraform applyterraform fmtcheckIntended location
Yes, this sample will be (or already is) included on cloud.google.com
Location(s):
No, this sample won't be included on cloud.google.com
Reason:
API enablement
Review