feat(VPC Flow Logs): Prepare VPC Flow Logs for inclusion in C.G.C. documentation #764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is the summary of changes. You are about to add 12 region tags.
This comment is generated by snippet-bot.
|
alkobi-google
changed the title
Contributor
|
/gcbrun |
glasnt
requested changes
Dec 9, 2024
Contributor
glasnt
left a comment
glasnt
left a comment
There was a problem hiding this comment.
I've reviewed one of the four changes, but most comments apply to other samples. Will also reply in your bug with more information
network_management/vpc_flow_logs_config/interconnect_attachment_basic/main.tf
Outdated
Show resolved
Hide resolved
network_management/vpc_flow_logs_config/interconnect_attachment_basic/main.tf
Outdated
Show resolved
Hide resolved
network_management/vpc_flow_logs_config/interconnect_attachment_basic/main.tf
Outdated
Show resolved
Hide resolved
network_management/vpc_flow_logs_config/interconnect_attachment_basic/main.tf
Outdated
Show resolved
Hide resolved
network_management/vpc_flow_logs_config/interconnect_attachment_basic/main.tf
Outdated
Show resolved
Hide resolved
Changed the directory name Simplified the region tag Removed unnecessary comments.
Contributor
|
This changes look like they might work; I have some suggestions based on syntax (using multiple region tags for documentation clarity), but the major issue is the functionality now, so let's run CI. /gcbrun |
Contributor
|
/gcbrun |
Contributor
|
/gcbrun |
glasnt
approved these changes
Dec 19, 2024
niharika-98
pushed a commit
to niharika-98/terraform-docs-samples
that referenced
this pull request
Sep 7, 2025
…cumentation (terraform-google-modules#764) * Prepare VPC Flow Logs for inclusion in C.G.C. documentation * Prepare VPC Flow Logs for inclusion in C.G.C. documentation * Prepare VPC Flow Logs for inclusion in C.G.C. documentation * Prepare VPC Flow Logs for inclusion in C.G.C. documentation * Fix description * Fix code review comments: Changed the directory name Simplified the region tag Removed unnecessary comments. * Fix all of the demo files to create every resource needed for the vpc flow logs. * Fix lint errors * Fix lint error. * Change region tags to differentiate between the setup and the VPC Flow Logs Config. * Fix lint errors --------- Co-authored-by: Katie McLaughlin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #
Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.
Checklist
Readiness
Style
guide
Testing
I have performed tests described in the Contributing guide:
terraform applyterraform fmtcheckIntended location
Yes, this sample will be (or already is) included on cloud.google.com
Location(s): https://cloud.google.com/vpc/docs/using-flow-logs
No, this sample won't be included on cloud.google.com
Reason:
API enablement
Review