-
Notifications
You must be signed in to change notification settings - Fork 286
feat(compute): create sample for Disk Async Replication feature #770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(compute): create sample for Disk Async Replication feature #770
Conversation
|
Here is the summary of changes. You are about to add 4 region tags.
This comment is generated by snippet-bot.
|
msampathkumar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nice work. Please wait for the CICD to pass before merging!
|
/gcbrun |
|
/gcbrun |
|
Sample is correct and tests successfully, unrelated error in CI ( #778 ) |
…aform-google-modules#770) * Added terraform-doc-sample for Async PD * added async replication * added parent tag * fixed the region violation comments --------- Co-authored-by: Katie McLaughlin <[email protected]>
Description
Fixes #
Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.
Checklist
Readiness
Style
guide
Testing
I have performed tests described in the Contributing guide:
terraform applyterraform fmtcheckIntended location
Yes, this sample will be (or already is) included on cloud.google.com
Location(s):
No, this sample won't be included on cloud.google.com
Reason:
API enablement
Review