Skip to content

Conversation

@camiekim
Copy link
Contributor

@camiekim camiekim commented Dec 13, 2024

Per b/355941670

Associate workflow w/dedicated SA that can write logs

Description

Fixes #

Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.

Checklist

Readiness

  • [ x] Yes, merge this PR after it is approved
  • No, don't merge this PR after it is approved

Style

Testing

  • [x ] I have performed tests described in the Contributing guide:

    • [x ] Tests pass: terraform apply
    • [x ] Lint pass: terraform fmt check

Intended location

API enablement

  • If the sample needs an API enabled to pass testing, I have added the service to the Test setup file

Review

  • If this sample adds a new directory, I have added codeowners to the CODEOWNERS file

Per b/355941670

Associate workflow w/dedicated SA that can write logs
@camiekim camiekim requested review from a team as code owners December 13, 2024 21:48
Apply terraform fmt
@glasnt
Copy link
Contributor

glasnt commented Dec 16, 2024

Sample failure:

Error: Error creating Trigger: googleapi: Error 403: Permission "storage.buckets.get" denied on "Bucket \"trigger-workflows-ci-tf-samples-foobar\" could not be validated. Please verify that the bucket exists and that the Eventarc service account has permission."

Re-running to verify: /gcbrun

@glasnt glasnt merged commit 9545b18 into terraform-google-modules:main Jan 6, 2025
4 checks passed
@camiekim camiekim deleted the b355941670 branch March 21, 2025 16:57
niharika-98 pushed a commit to niharika-98/terraform-docs-samples that referenced this pull request Sep 7, 2025
…aform-google-modules#783)

* docs: Update main.tf

Per b/355941670

Associate workflow w/dedicated SA that can write logs

* docs: Update main.tf

Apply terraform fmt

---------

Co-authored-by: Katie McLaughlin <[email protected]>
Co-authored-by: Jennifer Davis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants