Skip to content

Conversation

@duvni
Copy link
Contributor

@duvni duvni commented Jan 13, 2025

Description

Fixes #389579525

Adding samples for creating a simple consumer and producer setup of Network Security Out-of-band Integration using the mirroring Terraform resources.

Checklist

Readiness

  • Yes, merge this PR after it is approved
  • No, don't merge this PR after it is approved

Style

Testing

Intended location

API enablement

  • If the sample needs an API enabled to pass testing, I have added the service to the Test setup file

Review

  • If this sample adds a new directory, I have added codeowners to the CODEOWNERS file

@duvni duvni requested review from a team as code owners January 13, 2025 13:01
@snippet-bot
Copy link

snippet-bot bot commented Jan 13, 2025

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@glasnt
Copy link
Contributor

glasnt commented Jan 14, 2025

/gcbrun

@duvni duvni requested a review from glasnt January 16, 2025 20:13
glasnt added a commit that referenced this pull request Jan 19, 2025
glasnt added a commit that referenced this pull request Jan 19, 2025
@glasnt glasnt requested a review from a team as a code owner January 19, 2025 23:34
@glasnt glasnt merged commit 48fd8a0 into terraform-google-modules:main Jan 19, 2025
5 checks passed
@duvni duvni deleted the bug-389579525 branch January 20, 2025 07:46
niharika-98 pushed a commit to niharika-98/terraform-docs-samples that referenced this pull request Sep 7, 2025
niharika-98 pushed a commit to niharika-98/terraform-docs-samples that referenced this pull request Sep 7, 2025
…r mirroring (terraform-google-modules#798)

* feat(networksecurity): Add examples for creating consumer and producer mirroring

* Enable networksecurity API

* Add codeowners for network security's mirroring samples

* Use default as Terraform resource names where possible

* Rename association resource to default

* Fix tab discrepancy in CODEOWNERS file

---------

Co-authored-by: Katie McLaughlin <[email protected]>
Co-authored-by: Jennifer Davis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants