feat(cloud_sql): Add cloud sql psa+psc connectivity samples

[loeng2023]

Description

Fixes 383556956

Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.

Checklist

Readiness

• Yes, merge this PR after it is approved
• No, don't merge this PR after it is approved

Style

• My sample follows the rules described for Terraform in the Effective Samples style guide
• My sample follows the other requirements and best practices in the Contributing
  guide

Testing

• I have performed tests described in the Contributing guide:

  • Tests pass: terraform apply
  • Lint pass: terraform fmt check

Intended location

• Yes, this sample will be (or already is) included on cloud.google.com
  Location(s):

• No, this sample won't be included on cloud.google.com
  Reason:

API enablement

• If the sample needs an API enabled to pass testing, I have added the service to the Test setup file

Review

• If this sample adds a new directory, I have added codeowners to the CODEOWNERS file

[snippet-bot]

Here is the summary of changes.

You are about to add 6 region tags.

• cloud_sql/mysql_instance_psa_psc/main.tf:18, tag cloud_sql_mysql_instance_psa_psc_parent_tag
• cloud_sql/mysql_instance_psa_psc/main.tf:39, tag cloud_sql_mysql_instance_psa_psc_instance
• cloud_sql/postgres_instance_psa_psc/main.tf:18, tag cloud_sql_postgres_instance_psa_psc_parent_tag
• cloud_sql/postgres_instance_psa_psc/main.tf:39, tag cloud_sql_postgres_instance_psa_psc_instance
• cloud_sql/sqlserver_instance_psa_psc/main.tf:18, tag cloud_sql_sqlserver_instance_psa_psc_parent_tag
• cloud_sql/sqlserver_instance_psa_psc/main.tf:39, tag cloud_sql_sqlserver_instance_psa_psc_instance

---

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

• Refresh this comment

[jackwotherspoon]

Region tags must be globally unique, there are a lot of files here that are duplicating region tags from other files.

Let's remove the duplicate ones, that way the code samples in our docs will have one source of truth 😄

[glasnt]

/gcbrun

[jackwotherspoon]

I think we still need to be more careful with the region tags. We do not need to add region tags around pieces of code that are identical from one MySQL file to another MySQL file and which already has region tags. This PR should focus on adding region tags solely around code pieces that are new logic and contain PSA + PSC functionality.

Suggestions should be applied to Postgres and SQL Server as well.

This will make the code much more maintainable in the future and prevent having three different region tags around identical code blocks, leading to one source of truth for docs.

[jackwotherspoon]

LGTM ✅

[jackwotherspoon]

/gcbrun

[jackwotherspoon]

/gcbrun