-
Notifications
You must be signed in to change notification settings - Fork 286
feat: Add no channel to release channel samples for GKE #820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add no channel to release channel samples for GKE #820
Conversation
|
/gcbrun |
apeabody
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cslink!
|
Here is the summary of changes. You are about to add 4 region tags.
This comment is generated by snippet-bot.
|
|
/gcbrun |
|
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cslink!
I recommend using the id as that is the full projects/{{project}}/locations/{{location}}/clusters/{{cluster}}. Otherwise you will also want to set the location to google_container_cluster.rc_none.location
Co-authored-by: Andrew Peabody <[email protected]>
Co-authored-by: Andrew Peabody <[email protected]>
|
/gcbrun |
apeabody
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cslink!
…ogle-modules#820) * Terraform samples for switching no channel cluster to a release channel. --------- Co-authored-by: Andrew Peabody <[email protected]>
Description
Fixes # b/396134995
Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.
Checklist
Readiness
Style
guide
Testing
I have performed tests described in the Contributing guide:
terraform applyterraform fmtcheckIntended location
Yes, this sample will be (or already is) included on cloud.google.com
Location(s): https://cloud.google.com/kubernetes-engine/docs/how-to/release-channels
No, this sample won't be included on cloud.google.com
Reason:
API enablement
Review