Skip to content

Conversation

@cslink
Copy link
Contributor

@cslink cslink commented Mar 7, 2025

Description

Fixes # b/396134995

Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.

Checklist

Readiness

  • Yes, merge this PR after it is approved
  • No, don't merge this PR after it is approved

Style

Testing

Intended location

API enablement

  • If the sample needs an API enabled to pass testing, I have added the service to the Test setup file

Review

  • If this sample adds a new directory, I have added codeowners to the CODEOWNERS file

@apeabody apeabody changed the title Add no channel to release channel samples for GKE feat: Add no channel to release channel samples for GKE Mar 7, 2025
@apeabody
Copy link
Contributor

apeabody commented Mar 8, 2025

/gcbrun

@apeabody apeabody self-assigned this Mar 8, 2025
Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cslink!

@cslink cslink marked this pull request as ready for review March 12, 2025 00:48
@cslink cslink requested review from a team as code owners March 12, 2025 00:48
@snippet-bot
Copy link

snippet-bot bot commented Mar 12, 2025

Here is the summary of changes.

You are about to add 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@apeabody
Copy link
Contributor

/gcbrun

@apeabody
Copy link
Contributor

/gcbrun

Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cslink!

I recommend using the id as that is the full projects/{{project}}/locations/{{location}}/clusters/{{cluster}}. Otherwise you will also want to set the location to google_container_cluster.rc_none.location

@apeabody
Copy link
Contributor

/gcbrun

Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cslink!

@apeabody apeabody merged commit 2ff1900 into terraform-google-modules:main Mar 13, 2025
5 checks passed
niharika-98 pushed a commit to niharika-98/terraform-docs-samples that referenced this pull request Sep 7, 2025
…ogle-modules#820)

* Terraform samples for switching no channel cluster to a release channel.
---------
Co-authored-by: Andrew Peabody <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants