Skip to content

feat: Clarify maintenance exclusion usage in no channel to release channel samples for GKE #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Mar 14, 2025
Merged

feat: Clarify maintenance exclusion usage in no channel to release channel samples for GKE #823

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
c80cf41
Terraform samples for switching no channel cluster to a release channel.
cslink Mar 7, 2025
ad5872b
Terraform samples for switching no channel cluster to a release channel.
cslink Mar 7, 2025
d2ebf02
Merge branch 'main' into no-channel-to-release-channel-samples
cslink Mar 12, 2025
93d94ca
Terraform samples for switching no channel cluster to a release channel.
cslink Mar 7, 2025
c7cc8a1
Remove trailing whitespace.
cslink Mar 12, 2025
6cc7199
us-central1-d -> us-central1-f
cslink Mar 12, 2025
e6b3ecb
Update gke/standard/zonal/no-channel-to-release-channel/main.tf
cslink Mar 12, 2025
8b03bc6
Apply suggestions from code review
cslink Mar 12, 2025
7fa9694
Add comments on NO_UPGRADES exclusion to give advice on how to pick the
cslink Mar 13, 2025
d54982b
Add comment to all exclusions
cslink Mar 13, 2025
c6e8a10
fix whitespace
cslink Mar 13, 2025
44b86df
fix whitespace
cslink Mar 13, 2025
8ceddc9
Merge branch 'main' into no-channel-to-release-channel-samples
cslink Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions gke/standard/zonal/no-channel-to-release-channel/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,10 @@ resource "google_container_cluster" "no_upgrade" {
}
maintenance_exclusion {
exclusion_name = "no_upgrades_exclusion"
start_time = "2025-02-11T23:16:39Z"
# NOTE: Pick an interval for your exclusion with an end_time in the future
# otherwise the exclusion will have no effect.
# This example assumes that the exclusion is set on 2025-02-11.
start_time = "2025-02-11T23:16:39Z"
# NO_UPGRADES exclusions are limited to 30 days.
end_time = "2025-03-11T23:16:39Z"
exclusion_options {
Expand Down Expand Up @@ -112,8 +115,11 @@ resource "google_container_cluster" "rc_regular" {
}
maintenance_exclusion {
exclusion_name = "no_upgrades_exclusion"
start_time = "2025-02-11T23:16:39Z"
end_time = "2025-03-11T23:16:39Z"
# NOTE: Pick an interval for your exclusion with an end_time in the future
# otherwise the exclusion will have no effect.
# This example assumes that the exclusion is set on 2025-02-11.
start_time = "2025-02-11T23:16:39Z"
end_time = "2025-03-11T23:16:39Z"
exclusion_options {
scope = "NO_UPGRADES"
}
Expand Down Expand Up @@ -160,7 +166,10 @@ resource "google_container_cluster" "no_minor_or_node_upgrade" {
}
maintenance_exclusion {
exclusion_name = "no_minor_or_node_upgrades_exclusion"
start_time = "2025-02-11T23:16:39Z"
# NOTE: Pick an interval for your exclusion with an end_time in the future
# otherwise the exclusion will have no effect.
# This example assumes that the exclusion is set on 2025-02-11.
start_time = "2025-02-11T23:16:39Z"
# This the end of standard support for 1.31.
end_time = "2025-12-22T00:00:00Z"
exclusion_options {
Expand Down