Skip to content

docs: clarify placeholder values in custom_domain_mapping example #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 6, 2025
Merged

docs: clarify placeholder values in custom_domain_mapping example #833

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1bc9458
docs: clarify placeholder values in custom_domain_mapping example
hivanalejandro Apr 1, 2025
922b046
docs: clarify placeholder usage without breaking sample
hivanalejandro Apr 4, 2025
a434881
Merge branch 'main' into 372570764-update-custom-domain-doc
glasnt Apr 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions run/custom_domain_mapping/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,14 @@
# [START cloudrun_custom_domain_mapping_parent_tag]
# [START cloudrun_custom_domain_mapping_run_service]
resource "google_cloud_run_v2_service" "default" {
name = "custom-domain"
name = "custom-domain" # Replace with your service name
location = "us-central1"

deletion_protection = false # set to true to prevent destruction of the resource

template {
containers {
image = "us-docker.pkg.dev/cloudrun/container/hello"
image = "us-docker.pkg.dev/cloudrun/container/hello" # Replace with your container image
}
}
}
Expand Down