Skip to content

Conversation

@duvni
Copy link
Contributor

@duvni duvni commented Apr 6, 2025

Description

Adding samples for Security Profile, Security Profile Group and Global Firewall Policy, to showcase how an "apply_security_profile_group" rule is added.

CI tests are skipped since there are permission issues with org/folder level resources.
Local testing was performed successfully.

Checklist

Readiness

  • Yes, merge this PR after it is approved
  • No, don't merge this PR after it is approved

Style

Testing

Intended location

  • Yes, this sample will be (or already is) included on cloud.google.com
    Location(s):

  • No, this sample won't be included on cloud.google.com
    Reason:

API enablement

  • If the sample needs an API enabled to pass testing, I have added the service to the Test setup file

Review

  • If this sample adds a new directory, I have added codeowners to the CODEOWNERS file

@duvni duvni requested review from a team as code owners April 6, 2025 13:47
@snippet-bot
Copy link

snippet-bot bot commented Apr 6, 2025

Here is the summary of changes.

You are about to add 6 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@duvni duvni requested a review from adamglt April 6, 2025 13:48
@glasnt
Copy link
Contributor

glasnt commented Apr 9, 2025

There's a mismatch here between this sample working if you run it as a user with org/folder level permissions to make these changes, and the CI system having the same permissions.

I don't think this is a level of access we want to grant CI. We can still accept this sample as is, but with an added test.yaml file to skip the terraform apply step (the terraform will still be validated by CI)

@duvni duvni merged commit 74fe876 into terraform-google-modules:main Apr 9, 2025
5 checks passed
@duvni duvni deleted the tppi branch April 9, 2025 07:26
niharika-98 pushed a commit to niharika-98/terraform-docs-samples that referenced this pull request Sep 7, 2025
…on (terraform-google-modules#835)

* feat(networksecurity): Add samples for intercept firewall rule creation

* feat(networksecurity): Add samples for intercept firewall rule creation

* Skip consumer test.

---------

Co-authored-by: Katie McLaughlin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants