-
Notifications
You must be signed in to change notification settings - Fork 286
feat(networksecurity): Add samples for intercept firewall rule creation #835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Here is the summary of changes. You are about to add 6 region tags.
This comment is generated by snippet-bot.
|
|
There's a mismatch here between this sample working if you run it as a user with org/folder level permissions to make these changes, and the CI system having the same permissions. I don't think this is a level of access we want to grant CI. We can still accept this sample as is, but with an added |
…on (terraform-google-modules#835) * feat(networksecurity): Add samples for intercept firewall rule creation * feat(networksecurity): Add samples for intercept firewall rule creation * Skip consumer test. --------- Co-authored-by: Katie McLaughlin <[email protected]>
Description
Adding samples for Security Profile, Security Profile Group and Global Firewall Policy, to showcase how an "apply_security_profile_group" rule is added.
CI tests are skipped since there are permission issues with org/folder level resources.
Local testing was performed successfully.
Checklist
Readiness
Style
guide
Testing
I have performed tests described in the Contributing guide:
terraform applyterraform fmtcheckIntended location
Yes, this sample will be (or already is) included on cloud.google.com
Location(s):
No, this sample won't be included on cloud.google.com
Reason:
API enablement
Review